Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding header settings to HTTP health check #1896

Closed
samber opened this issue Mar 30, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@samber
Copy link

commented Mar 30, 2016

Hi guys,

I'm writing this issue to discuss about an improvement.

Today, Consul is able to perform an HTTP health-check with a defined route (ex: /health).
It would be awesome to send a request with custom fields set in the HTTP header.
In this way, it should be possible to test:

  • the routing rules of a reverse proxy with the field Host,
  • an authentication with the field Authorization or custom
  • or even test CORS with Origin.

To illustrate:
adding: req.Header.Set("Host", "foo.bar.example.com")
here: https://github.com/hashicorp/consul/blob/master/command/agent/check.go#L415

It can be done with scripting+curl, but using the http health check would be the best practice.

Rgds

@slackpad

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2016

Hi @samber thanks for opening an issue, I'm going to close this as a duplicate of #1184.

@slackpad slackpad closed this Apr 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.