Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist acl_agent_token etc. when set using the API #4333

Closed
ac-astuartkregor opened this issue Jul 3, 2018 · 4 comments
Closed

Persist acl_agent_token etc. when set using the API #4333

ac-astuartkregor opened this issue Jul 3, 2018 · 4 comments

Comments

@ac-astuartkregor
Copy link

@ac-astuartkregor ac-astuartkregor commented Jul 3, 2018

Feature Description

Currently the agent APIs that let you set the acl_agent_token and others (these ones) do not cause the agent token to be persisted, and therefore the token must be set every time the agent restarts:

Tokens are not persisted, so will need to be updated again if the agent is restarted.

It would be very useful if the token was persisted, in line with the master ACL bootstrap API.

Use Case(s)

  • Using the APIs for automation of consul provisioning and ACL bootstrapping.
  • Prevents mangling of config files and easier automation.
  • Consistency with existing APIs for ACLs.
@ac-astuartkregor ac-astuartkregor changed the title Persist acl_agent_token when set using the API Persist acl_agent_token etc. when set using the API Jul 3, 2018
@timmehhh7
Copy link

@timmehhh7 timmehhh7 commented Oct 27, 2018

Seeing this behaviour as well. To add to the use cases:

  • Kubernetes/Docker based deployments - wanting to bootstrap for automation and pods/containers can't be restarted.
@joewilliams
Copy link

@joewilliams joewilliams commented Apr 23, 2019

Has there been any movement or updates on this issue?

@joewilliams
Copy link

@joewilliams joewilliams commented Apr 23, 2019

Seems like enable_token_persistence = true was added in 1.4.3 which I think fixes this issue.

@mkeeler
Copy link
Member

@mkeeler mkeeler commented Apr 23, 2019

@joewilliams Yep, going to close this as that was implemented in 1.4.3.

@mkeeler mkeeler closed this Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants