Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: ACL Tokens can now be assigned an optional set of service identities #5390

Merged
merged 1 commit into from Apr 8, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Feb 26, 2019

Parent PR: #5353
Note: this is merging into a long lived feature branch, not master. Future PRs in this series may adjust the contents here slightly as needed. These are separated out for digestibility.

These act like a special cased version of a Policy Template for granting a token the privileges necessary to register a service and its connect proxy, and read upstreams from the catalog.

  • Validate that the CLI changes are sane
  • website updates
  • UI updates

@rboyer rboyer added theme/acls ACL and token generation theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies labels Feb 26, 2019
@rboyer rboyer self-assigned this Feb 26, 2019
@rboyer rboyer requested a review from a team February 26, 2019 18:44
@rboyer rboyer force-pushed the f-acl-service-identities branch 2 times, most recently from 024c5e6 to 26b9c9a Compare March 4, 2019 20:28
@rboyer rboyer requested a review from mkeeler March 25, 2019 18:14
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level read through 👍

@rboyer rboyer added this to the 1.5.0 milestone Apr 8, 2019
@rboyer rboyer changed the base branch from f-token-expiration to f-acl-ux April 8, 2019 17:15
…ties

These act like a special cased version of a Policy Template for granting
a token the privileges necessary to register a service and its connect
proxy, and read upstreams from the catalog.
@rboyer rboyer merged commit d79fe76 into f-acl-ux Apr 8, 2019
@rboyer rboyer deleted the f-acl-service-identities branch April 8, 2019 18:36
rboyer added a commit that referenced this pull request Apr 24, 2019
…ties (#5390)

These act like a special cased version of a Policy Template for granting
a token the privileges necessary to register a service and its connect
proxy, and read upstreams from the catalog.
rboyer added a commit that referenced this pull request Apr 26, 2019
…ties (#5390)

These act like a special cased version of a Policy Template for granting
a token the privileges necessary to register a service and its connect
proxy, and read upstreams from the catalog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/acls ACL and token generation theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants