New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/document reliable way to figure out if server node joined cluster successfully #880

Closed
discordianfish opened this Issue Apr 22, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@discordianfish
Contributor

discordianfish commented Apr 22, 2015

Hi,

I'm trying to create a AWS AutoScaling configuration to fully automate rolling upgrades of my consul nodes. The idea is that the ASG will terminate one instance, create a new one and wait with the next one until I signal success for the first one.
Now I need to know when a consul server node successfully joined the cluster (-> has all state and is part of the cluster), aka when it's save to kill another server node, so I can signal success.

I might be able to check if the node is in /v1/status/peers but I'm not sure this goes through the raft log and is guaranteed to be consistent. Or I assume that a node sucesffully joined as soon as /v1/status/leader returns something, but same here - I'm not sure about the consistency guarantees.

So if there is a way to programatically tell that a node successfully joined it should be documented. If not, I think it would be useful to have a API endpoint for that.

@armon

This comment has been minimized.

Show comment
Hide comment
@armon

armon Apr 23, 2015

Member

The /v1/status/peers does require a Raft log to be updated, so if that is updated, then you should be good to go!

Member

armon commented Apr 23, 2015

The /v1/status/peers does require a Raft log to be updated, so if that is updated, then you should be good to go!

@discordianfish

This comment has been minimized.

Show comment
Hide comment
@discordianfish

discordianfish Apr 23, 2015

Contributor

@armon Great, thanks! I think this should be documented? I'd say this is a concern everyone who is replacing nodes in the cluster automatically has. But I'm good, so feel free to close this ticket if you want.

Contributor

discordianfish commented Apr 23, 2015

@armon Great, thanks! I think this should be documented? I'd say this is a concern everyone who is replacing nodes in the cluster automatically has. But I'm good, so feel free to close this ticket if you want.

@ryanuber ryanuber closed this in dd57071 May 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment