Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [NET-9098] Narrow scope of peering config on terminating gw filter chain to TCP services into release/1.18.x #21057

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #21054 to be assessed for backporting due to the inclusion of the label backport/1.18.

The below text is copied from the body of the original PR.


Description

This narrows the scope of changes made previously in #19881 which have unintentionally impacted http config on terminating gateway filter chains

Testing & Reproduction steps

Run the consul-k8s peering acceptance test with transparent proxy and CNI flavors using a build of this consul-enterprise branch. The test that is currently broken should pass with this build.

Example:

$ cd consul-k8s
$ make kind-small
$ cd acceptance
$ go test ./tests/peering -v -p 1 -timeout 20m -count=1 -run ^TestPeering_Connect$ \
        -enable-multi-cluster -kube-contexts="kind-dc1,kind-dc2" -use-kind \
        -enable-transparent-proxy -consul-image '<image here>'

There are existing xDS golden tests that cover TCP services. Those updates can be seen in #19881.

Additionally, we have followup work to add tcp-specific peering acceptance test coverage where there isn't any today. This is followup work so that we can go ahead and unblock the failing tests and upcoming release over in the consul-k8s repo.

Links

Example acceptance test failure in consul-k8s

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@nathancoleman nathancoleman enabled auto-merge (squash) May 6, 2024 20:21
@nathancoleman nathancoleman merged commit 537b50e into release/1.18.x May 6, 2024
82 checks passed
@nathancoleman nathancoleman deleted the backport/tcp-filter-chain-tgw/literally-ethical-mite branch May 6, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants