Call RemoveServer for reap events #5317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In both the leaving and reaping case the server is no longer available and therefore we must remove it from our list of servers.
|
Still need to do some more digging here. There might be a LAN router problem too. |
This ensures we add/remove updated/failed servers properly.
|
There definitely was a LAN router problem. In fact all 3 places that handled the serf events were wrong. The resulting behavior is that servers stuck around in our RPC routers even after they had been reaped by serf. This would persist until the node rejoined or the node was restarted. |
I dont think this will cause a problem to ignore after further investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both the leaving and reaping case the server is no longer available and therefore we must remove it from our list of servers.
If we do not remove servers for a reap event they may stay around forever until the node gets restarted.
Update: Also ensure that
EventMemberUpdateevents are handled just like joins to updated the server info.AddServersinternally handles update vs new addition.