Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: ensure that updates to the secondary root CA configuration use the correct signing key ID values for comparison #7012

Merged
merged 1 commit into from Jan 9, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jan 8, 2020

Fixes #6886

…se the correct signing key ID values for comparison

Fixes #6886
@rboyer rboyer added the theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies label Jan 8, 2020
@rboyer rboyer self-assigned this Jan 8, 2020
@rboyer rboyer requested review from banks and a team January 8, 2020 22:09
@rboyer rboyer added this to the 1.7.0 milestone Jan 8, 2020
@rboyer rboyer marked this pull request as ready for review January 8, 2020 22:09
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@hanshasselberg hanshasselberg merged commit 50c8799 into master Jan 9, 2020
@hanshasselberg hanshasselberg deleted the avoid-useless-regeneration-of-secondary-ca branch January 9, 2020 15:28
hanshasselberg pushed a commit that referenced this pull request Jan 9, 2020
…se the correct signing key ID values for comparison (#7012)

Fixes #6886
@hanshasselberg hanshasselberg mentioned this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secondary CA Cert is generated twice during initialization
2 participants