Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Add ability to search nodes listing page with IP Address #7204

Merged
merged 1 commit into from
Feb 4, 2020
Merged

ui: Add ability to search nodes listing page with IP Address #7204

merged 1 commit into from
Feb 4, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Feb 3, 2020 •
edited
Loading

  • Update search field placeholder to display Search

  • Add an acceptance test to search node listings with node name and IP Address

  • Update and add unit tests for filter/search node listing with IP Address

TBT

@kaxcode kaxcode added the theme/ui Anything related to the UI label Feb 3, 2020
@kaxcode kaxcode requested a review from a team February 3, 2020 22:04
johncowen
johncowen approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another lovely PR @kaxcode . I left a couple of comments. I think this is still fine to merge as is as the feature works great, but would be good to get that unit test covered if poss. Let's catch up later.

ui-v2/tests/acceptance/dc/nodes/index.feature Show resolved Hide resolved
ui-v2/tests/unit/search/filters/node-test.js Show resolved Hide resolved
@kaxcode
Add ability to search nodes listing page with IP Address
13ae5c0 
* Update search field placeholder to display `Search`

* Add an acceptance test to search node listings with node name and IP Address

* Update and add unit tests for filter/search node listing with IP Address
@kaxcode kaxcode force-pushed the feature/search-node-listings-with-ip-address branch from 2586859 to 13ae5c0 Compare February 4, 2020 14:31
@kaxcode kaxcode merged commit 773b092 into ui-staging Feb 4, 2020
@kaxcode kaxcode deleted the feature/search-node-listings-with-ip-address branch February 4, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaxcode @johncowen