Fix envoy config when both RetryOn* values are set #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crhino
changed the title
|
Decided against adding an Envoy integration test for this since the setup/testing would be fairly complex, and hopefully the |
banks
approved these changes
Feb 13, 2020
banks
reviewed
Feb 13, 2020
| @@ -129,7 +129,7 @@ func makeUpstreamRouteForDiscoveryChain( | |||
| } | |||
| if len(destination.RetryOnStatusCodes) > 0 { | |||
| if retryPolicy.RetryOn != "" { | |||
| retryPolicy.RetryOn = ",retriable-status-codes" | |||
| retryPolicy.RetryOn = retryPolicy.RetryOn + ",retriable-status-codes" | |||
There was a problem hiding this comment.
I guess the original intent was to use +=... It's easier to see it's correct with the more explicit concatenation though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7209