grpc: use default resolver scheme for grpc dialing #7617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently checks of type gRPC will emit log messages such as,
Without adding full support for using custom gRPC schemes (perhaps that's
right long-term option) we can just supply the default scheme as provided
by the grpc library.
Fixes #7274
and transitively hashicorp/nomad#7415
Did some manual testing.
Without Proxy
Toy gRPC HC service
Consul config w/ check on service
Run Consul
Verify check passes
With Proxy (using Nomad)
Run Consul
Run Nomad
Nomad job file w/ Connect enabled, exposed gRPC HC service
Wait for job to become healthy
Verify check is passing