ui: Create Upstreams tab for Ingress Gateways #7865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
approved these changes
May 13, 2020
There was a problem hiding this comment.
I said quite a little bit here, but I think the only important things are the spelling errors, and possibly looking into that Address thing. Anything else could be looked at later, but if you are in here and its no bother better to sort now, kinda up to you what you want to hit now.
kaxcode
force-pushed
the
ui/feature/create-upstreams-tab-for-ingress-gateways
branch
from
331bbae
to
78fb08d
Compare
kaxcode
added a commit
that referenced
this pull request
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an opportunity to create a ConsulGatewayServicesList component shared by both Upstreams and Linked Services. For now, the lists share a class for styling but have different content.
Upstreams tab:
Tooltip changes:
