New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVE-2020-13250: Cache DoS / OOM #8023
Merged
hanshasselberg
merged 2 commits into
hashicorp:master
from
hanshasselberg:disable_http_cache
Jun 8, 2020
Merged
CVE-2020-13250: Cache DoS / OOM #8023
hanshasselberg
merged 2 commits into
hashicorp:master
from
hanshasselberg:disable_http_cache
Jun 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the operator to disable agent caching for the http endpoint. It is on by default for backwards compatibility and if disabled will ignore the url parameter `cached`.
Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>
da434fc
to
5973e9f
Compare
mkeeler
approved these changes
Jun 5, 2020
hanshasselberg
added a commit
that referenced
this pull request
Jun 8, 2020
This allows the operator to disable agent caching for the http endpoint. It is on by default for backwards compatibility and if disabled will ignore the url parameter `cached`.
hanshasselberg
added a commit
that referenced
this pull request
Jun 8, 2020
This allows the operator to disable agent caching for the http endpoint. It is on by default for backwards compatibility and if disabled will ignore the url parameter `cached`.
hanshasselberg
added a commit
that referenced
this pull request
Jun 8, 2020
This allows the operator to disable agent caching for the http endpoint. It is on by default for backwards compatibility and if disabled will ignore the url parameter `cached`.
hanshasselberg
added a commit
that referenced
this pull request
Jun 10, 2020
This allows the operator to disable agent caching for the http endpoint. It is on by default for backwards compatibility and if disabled will ignore the url parameter `cached`.
hanshasselberg
added a commit
that referenced
this pull request
Jun 10, 2020
* consul 1.7.4 * agent: add option to disable agent cache for HTTP endpoints (#8023) This allows the operator to disable agent caching for the http endpoint. It is on by default for backwards compatibility and if disabled will ignore the url parameter `cached`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
Consul’s DNS and HTTP API expose a caching feature susceptible to DoS.
Background
Consul v1.2.0 introduced an agent cache to ease management of proxy configuration on the agents, allowing caching in the HTTP API. Later v1.4.3 included the ability to turn on using the agent cache for DNS queries. While the cache has the ability to expire, or evict old entries, it does not have the ability to limit the cache’s size.
Remediation
Steps to remediate: