This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
Fix issue with ping not working within script checks #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17
/bin/ping
in alpine is normally a symlink to/bin/busybox
. On other distros/bin/ping
is a setuid binary to allow ICMP sockets to work for regular users.So there were 3 options:
1 -
chmod u+s /bin/ping
2 - Install a ping binary not associated with busybox
3 - Require users to configure the host linux to allow GID 1000 the ability to ping (sysctl net.ipv4.ping_group_range)
Number 1 would be terribly insecure as it actually makes the entire
/bin/busybox
binary setuid and almost every command in/bin
is actually just a symlink to/bin/busybox
. Number 3 puts the burden of configuration on the user and isn't a wonderful UX. Number 2 however only has the downsides of including a few extra binaries in the image. The size becomes a little larger but not by much.Therefore the iputils package was installed which provides real ping and ping6 binaries in addition to a handful of other utilities such as traceroute.