Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rename VAULT_VERSION environment variable in Dockerfile #140
Today I tried to get a custom database plugin running within the Vault docker container, only to face the error
After a bit of digging I found https://github.com/hashicorp/vault/blob/master/helper/pluginutil/env.go#L36 and tried changing the name of the
My simple fix is to refrain from setting
Instead of this PR it might be desired to fix the environment setting behavior in https://github.com/hashicorp/vault/blob/fb89af7cfa66b033951fa4c44ff31718537f094f/helper/pluginutil/runner.go#L81
Hi @chrishoffman, when a Dockerfile does
So the true bug appears to be with Vault not replacing the environment variable properly when spawning a plugin. Changing the naming in the Dockerfile is a simple workaround and may help avoid confusion.
Using ARG instead of ENV would also be good I think.