Skip to content
This repository has been archived by the owner on Mar 18, 2021. It is now read-only.

Switch consul resolver to use ServiceAddress #83

Merged
merged 2 commits into from
Sep 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion consul/service_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ func (sr *Resolver) updateCatalog(dep dependency.Dependency, cs []*dependency.Ca
for _, addr := range cs {
addresses = append(
addresses,
fmt.Sprintf("http://%v:%v", addr.Address, addr.ServicePort),
fmt.Sprintf("http://%v:%v", addr.ServiceAddress, addr.ServicePort),
)
}

Expand Down
14 changes: 8 additions & 6 deletions consul/service_resolver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ import (
func setup(t *testing.T, queryError error) (*Resolver, *MockWatcher, *cache.Cache, *MockServiceQuery) {

dep := &dependency.CatalogService{
ServiceName: "test",
Address: "myaddress",
ServicePort: 8080,
ServiceName: "test",
Address: "myaddress",
ServiceAddress: "myaddress",
ServicePort: 8080,
}
cs := []*dependency.CatalogService{dep}

Expand Down Expand Up @@ -128,9 +129,10 @@ func TestWatchWithNewServicesUpdatesCatalog(t *testing.T) {

w.data <- []*dependency.CatalogService{
&dependency.CatalogService{
ServiceName: "test",
Address: "mynewaddress",
ServicePort: 8081,
ServiceName: "test",
Address: "mynewaddress",
ServiceAddress: "mynewaddress",
ServicePort: 8081,
},
}

Expand Down