Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `cloud.google.com/go` version #201

Closed
wants to merge 1 commit into from

Conversation

@178inaba
Copy link
Contributor

commented Sep 4, 2019

I want to exclude git.apache.org/thrift.git because git.apache.org is down.
The latest cloud.google.com/go doesn't use git.apache.org/thrift.git, so updating it can eliminate git.apache.org/thrift.git.

The executed command is as follows.

$ go get cloud.google.com/go && go mod tidy
@hashicorp-cla

This comment has been minimized.

Copy link

commented Sep 4, 2019

CLA assistant check
All committers have signed the CLA.

@178inaba 178inaba force-pushed the 178inaba:update_google_package branch from 6acc5f9 to e66c024 Sep 4, 2019

@dmitshur

This comment has been minimized.

Copy link

commented Sep 5, 2019

I wanted to make a similar change. 👍

You can consider updating cloud.google.com/go to v0.37.4, which also no longer has git.apache.org/thrift.git, and is only 1 minor version higher than the current v0.36.0. That'd be a smaller change that accomplishes the same goal.

@apparentlymart

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Oh, hi @178inaba!

I just reached the same conclusion and created #204 before I noticed that you'd already opened this PR. I agree that this is a good fix because go-getter doesn't actually directly need this library anyway.

@azr

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Woops, I jumped the gun and merged @apparentlymart's issue; sorry !
Well the outcome is still good I think !! 🙂

Thanks all !

@azr azr closed this Sep 6, 2019

@178inaba 178inaba deleted the 178inaba:update_google_package branch Sep 6, 2019

@178inaba 178inaba restored the 178inaba:update_google_package branch Sep 6, 2019

@178inaba 178inaba deleted the 178inaba:update_google_package branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.