Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enabled property to Organization Run Tasks #382

Merged
merged 1 commit into from Apr 28, 2022

Conversation

glennsarti
Copy link
Contributor

@glennsarti glennsarti commented Apr 20, 2022

Description

The Organizational level run tasks have been updated with
an enabled property in the API. This commit adds this new
property to the Run Tasks interfaces.

Testing plan

  1. Create a Run Task in an organization
  2. Call RunTasks.Read(....)
  3. Ensure that the return RunTask object has Enabled set to the same that is in TFC.TFE

External links

cam-stitt
cam-stitt previously approved these changes Apr 20, 2022
Copy link
Member

@cam-stitt cam-stitt left a comment

LGTM

sebasslash
sebasslash previously approved these changes Apr 21, 2022
Copy link
Contributor

@sebasslash sebasslash left a comment

Yes indeed my good sir! 🔥

@glennsarti glennsarti dismissed stale reviews from sebasslash and cam-stitt via 920d796 Apr 22, 2022
@glennsarti glennsarti requested a review from sebasslash Apr 22, 2022
@glennsarti
Copy link
Contributor Author

glennsarti commented Apr 22, 2022

Forgot to add omitempty on the optional parameters.

cam-stitt
cam-stitt previously approved these changes Apr 26, 2022
The Organizationl level run tasks have been updated with
an `enabled` property in the API. This commit adds this new
property to the Run Tasks interfaces.
Copy link
Contributor

@sebasslash sebasslash left a comment

No new changes since last approval, re-approving 👍

@glennsarti glennsarti merged commit 5354461 into main Apr 28, 2022
4 checks passed
@glennsarti glennsarti deleted the gs/add-run-task-enable branch Apr 28, 2022
@github-actions
Copy link

github-actions bot commented Apr 28, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants