Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add List Registry Modules Endpoint #385

Merged
merged 4 commits into from Jun 8, 2022

Conversation

chroju
Copy link
Contributor

@chroju chroju commented Apr 23, 2022

Description

Add a support for List Registry Modules for an Organization API endpoint.

Testing plan

  1. Create an organization.
  2. Create some registry modules.
  3. Query the registry modules.

External links

Output from tests (HashiCorp employees only)

N/A

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 23, 2022

CLA assistant check
All committers have signed the CLA.

@chroju chroju changed the title Add registry module list Add List Registry Modules Endpoint Apr 23, 2022
sebasslash
sebasslash previously requested changes Apr 27, 2022
Copy link
Contributor

@sebasslash sebasslash left a comment

Code looks great! Since you've added new endpoints to an existing resource you'll need to re-generate the mocks. You can do so running ./generate-mocks.sh and then just push the edited files.

@sebasslash
Copy link
Contributor

sebasslash commented Apr 27, 2022

Oh forgot to mention, you'll need to rebase with main to fix the CI test failures!

@chroju
Copy link
Contributor Author

chroju commented Apr 28, 2022

@sebasslash
Thanks a lot! I have merged main to this branch and re-generated the mocks.

@chroju chroju requested a review from sebasslash Apr 28, 2022
@sebasslash sebasslash dismissed their stale review Jun 7, 2022

Changes addressed

Copy link
Contributor

@sebasslash sebasslash left a comment

🏇 🏁

@sebasslash sebasslash merged commit 5a2a37b into hashicorp:main Jun 8, 2022
4 checks passed
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

@chroju chroju deleted the add_registry_module_list branch Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Registry Modules
3 participants