Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft Teams notification destination type #389

Merged
merged 2 commits into from Jun 8, 2022

Conversation

JarrettSpiker
Copy link
Contributor

@JarrettSpiker JarrettSpiker commented May 3, 2022

Description

Adds microsoft_teams as a potential destination for notification configuration

The Terraform Cloud support for Microsoft Teams is currently being implemented, so queueing this (and the related tfe provider) change up fo

Blocked on:

  • TFC feature completion
  • Test output

Testing plan

Testing through use with the tfe provider, to check that terraform can be used to create, update, and destroy (+ validate) Microsoft Teams notification configurations on TFC

The required values for Teams notification config will be the same as for Slack notifications

External links

Output from tests (HashiCorp employees only)

❯ go test -run TestNotificationConfigurationCreate -tags=integration
PASS
ok  	github.com/hashicorp/go-tfe	45.437s
...

@JarrettSpiker JarrettSpiker marked this pull request as ready for review Jun 7, 2022
Copy link
Contributor

@sebasslash sebasslash left a comment

🎯 LGTM

@JarrettSpiker JarrettSpiker merged commit 26d3401 into main Jun 8, 2022
6 checks passed
@JarrettSpiker JarrettSpiker deleted the jspiker/ms-teams branch Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants