Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new runs list options #424

Merged
merged 1 commit into from Jun 27, 2022
Merged

Add new runs list options #424

merged 1 commit into from Jun 27, 2022

Conversation

mjyocca
Copy link
Contributor

@mjyocca mjyocca commented Jun 9, 2022

Description

Adds new RunsListOption(s) to accompany new query parameters recently added to TFC. These parameters are still in the process of being rolled out. New tests are currently skipped.

Testing plan

External links

API documentation has yet to be updated
Task Link

Output from tests

TFE_ADDRESS="https://example" \
TFE_TOKEN="example" \
TF_ACC="1" \
ENABLE_BETA="1" \
go test -run TestRunsListQueryParams -v -tags=integration

Output

=== RUN   TestRunsListQueryParams
=== RUN   TestRunsListQueryParams/with_status_query_parameter
=== RUN   TestRunsListQueryParams/with_source_query_parameter
=== RUN   TestRunsListQueryParams/with_operation_of_plan_only_parameter
=== RUN   TestRunsListQueryParams/with_name_parameter
=== RUN   TestRunsListQueryParams/with_name_&_commit_parameter
--- PASS: TestRunsListQueryParams (41.61s)
    --- PASS: TestRunsListQueryParams/with_status_query_parameter (0.45s)
    --- PASS: TestRunsListQueryParams/with_source_query_parameter (0.40s)
    --- PASS: TestRunsListQueryParams/with_operation_of_plan_only_parameter (0.34s)
    --- PASS: TestRunsListQueryParams/with_name_parameter (0.38s)
    --- PASS: TestRunsListQueryParams/with_name_&_commit_parameter (0.32s)
PASS
ok      github.com/hashicorp/go-tfe     42.556s

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 9, 2022

CLA assistant check
All committers have signed the CLA.

@mjyocca mjyocca marked this pull request as ready for review Jun 10, 2022
@mjyocca mjyocca requested review from omarismail and aaabdelgany Jun 10, 2022
run.go Outdated Show resolved Hide resolved
run_integration_test.go Outdated Show resolved Hide resolved
run_integration_test.go Outdated Show resolved Hide resolved
matejrisek
matejrisek previously approved these changes Jun 13, 2022
@mjyocca mjyocca force-pushed the mjyocca/runs-list-api-changes branch from 57b7215 to e9140c8 Compare Jun 13, 2022
@mjyocca mjyocca requested a review from matejrisek Jun 13, 2022
@mjyocca mjyocca force-pushed the mjyocca/runs-list-api-changes branch from e9140c8 to 8e033bf Compare Jun 13, 2022
matejrisek
matejrisek previously approved these changes Jun 14, 2022
omarismail
omarismail previously approved these changes Jun 14, 2022
@mjyocca mjyocca dismissed stale reviews from omarismail and matejrisek via e9179b7 Jun 14, 2022
@mjyocca mjyocca requested review from omarismail and matejrisek Jun 14, 2022
matejrisek
matejrisek previously approved these changes Jun 14, 2022
@barrettclark
Copy link
Contributor

barrettclark commented Jun 17, 2022

@mjyocca Once all the work we have in flight to address tests are done, you'll want to rebase main into this branch. Would you mind also squashing your commits when you do that?

@mjyocca
Copy link
Contributor Author

mjyocca commented Jun 21, 2022

@mjyocca Once all the work we have in flight to address tests are done, you'll want to rebase main into this branch. Would you mind also squashing your commits when you do that?

Don't mind at all :)

@mjyocca mjyocca force-pushed the mjyocca/runs-list-api-changes branch 2 times, most recently from fdeaa07 to 5965044 Compare Jun 27, 2022
Copy link
Contributor

@omarismail omarismail left a comment

lgtm

@mjyocca mjyocca merged commit 2cb5c65 into main Jun 27, 2022
9 checks passed
@mjyocca mjyocca deleted the mjyocca/runs-list-api-changes branch Jun 27, 2022
@github-actions
Copy link

github-actions bot commented Jun 27, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants