Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Changes for Agent Pools to Workspaces Feature #453

Merged
merged 9 commits into from Jul 12, 2022

Conversation

Netra2104
Copy link
Contributor

@Netra2104 Netra2104 commented Jul 4, 2022

Description

In Atlas, new features were added where the user can change the scope for agent pools to either the entire organization or to specific workspaces. The user can specify a list of allowed workspaces.

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ go-tfe % envchain go-tfe go test -run TestAgentPoolsUpdate -v ./... -tags=integration
=== RUN   TestAgentPoolsUpdate
=== RUN   TestAgentPoolsUpdate/with_valid_options
=== RUN   TestAgentPoolsUpdate/when_updating_the_name
=== RUN   TestAgentPoolsUpdate/without_a_valid_agent_pool_ID
=== RUN   TestAgentPoolsUpdate/when_updating_allowed-workspaces
=== RUN   TestAgentPoolsUpdate/when_updating_organization_scope
--- PASS: TestAgentPoolsUpdate (5.57s)
    --- PASS: TestAgentPoolsUpdate/with_valid_options (0.83s)
    --- PASS: TestAgentPoolsUpdate/when_updating_the_name (0.76s)
    --- PASS: TestAgentPoolsUpdate/without_a_valid_agent_pool_ID (0.00s)
    --- PASS: TestAgentPoolsUpdate/when_updating_allowed-workspaces (1.29s)
    --- PASS: TestAgentPoolsUpdate/when_updating_organization_scope (0.88s)
PASS
ok      github.com/hashicorp/go-tfe     (cached)
?       github.com/hashicorp/go-tfe/examples/organizations      [no test files]
?       github.com/hashicorp/go-tfe/examples/workspaces [no test files]
?       github.com/hashicorp/go-tfe/mocks       [no test files]
...

@Netra2104 Netra2104 requested a review from a team Jul 6, 2022
Copy link
Collaborator

@brandonc brandonc left a comment

Typically, unless this is a dependency for another change, we usually wait until new beta API features are generally available before releasing them in go-tfe, because we want this repo to mostly match what is in the API documentation.

agent_pool.go Outdated Show resolved Hide resolved
agent_pool_integration_test.go Show resolved Hide resolved
@Netra2104 Netra2104 requested a review from brandonc Jul 11, 2022
hs26gill
hs26gill previously approved these changes Jul 11, 2022
@Netra2104 Netra2104 requested review from hs26gill and jbonhag Jul 11, 2022
hs26gill
hs26gill previously approved these changes Jul 12, 2022
Copy link

@hs26gill hs26gill left a comment

Looks Great!

Copy link

@jbonhag jbonhag left a comment

Nice work!! 🎉

@Netra2104 Netra2104 merged commit 0568f29 into main Jul 12, 2022
6 checks passed
@Netra2104 Netra2104 deleted the Netra2104/scope-agent-api-tests branch Jul 12, 2022
@github-actions
Copy link

github-actions bot commented Jul 12, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants