New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes version parsing for versions including ~ #34

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
3 participants
@captn3m0
Contributor

captn3m0 commented Nov 1, 2017

@offlinehacker

This comment has been minimized.

Show comment
Hide comment
@offlinehacker

offlinehacker Nov 28, 2017

Will this be merge and new terraform released anytime soon?

offlinehacker commented Nov 28, 2017

Will this be merge and new terraform released anytime soon?

@mitchellh

This comment has been minimized.

Show comment
Hide comment
@mitchellh

mitchellh Nov 29, 2017

Member

Thanks @offlinehacker for the bump. This looks good to me.

As a note: strict SemVer doesn't allow ~ in this location. As I've said before, this library is more flexible than strict SemVer and I'm open to adding a "strict mode" in the future but given our current stance I'll merge this.

Thanks!

Member

mitchellh commented Nov 29, 2017

Thanks @offlinehacker for the bump. This looks good to me.

As a note: strict SemVer doesn't allow ~ in this location. As I've said before, this library is more flexible than strict SemVer and I'm open to adding a "strict mode" in the future but given our current stance I'll merge this.

Thanks!

@mitchellh mitchellh merged commit 713ad4b into hashicorp:master Nov 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@captn3m0 captn3m0 deleted the captn3m0:debian-fix branch Nov 29, 2017

@offlinehacker

This comment has been minimized.

Show comment
Hide comment
@offlinehacker

offlinehacker Nov 29, 2017

@mitchellh you should say thanks to @captn3m0, he made pull request, but thanks for the merge ;)

offlinehacker commented Nov 29, 2017

@mitchellh you should say thanks to @captn3m0, he made pull request, but thanks for the merge ;)

@captn3m0

This comment has been minimized.

Show comment
Hide comment
@captn3m0
Contributor

captn3m0 commented Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment