Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality improvements #67

merged 2 commits into from May 11, 2020

Code quality improvements #67

merged 2 commits into from May 11, 2020


Copy link

@paskal paskal commented May 9, 2020

  • Add golangci-lint configuration with sane set of checks
  • Fix discovered issues
  • Add GitHub Actions workflow for test and build and linter run

Copy link

hashicorp-cla commented May 9, 2020

CLA assistant check
All committers have signed the CLA.

arc_test.go Outdated Show resolved Hide resolved
Copy link

Thanks for updating! In the future please refrain from force-pushing as it doesn't allow reviewers to check just the changes you're making in response to review without going back and having to evaluate the whole thing again.

@jefferai jefferai merged commit eb52994 into hashicorp:master May 11, 2020
@paskal paskal deleted the code_quality branch May 11, 2020 16:21
@paskal paskal mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants