New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs.Version
to support version constrained binary discovery
#52
Conversation
Allows users to optionally specify one or more (comma separated) version constraints for `fs.AnyVersion` source.
Hi @magodo Aside from the name communicating better what the source represents we also wouldn't need to deal with conflicts with |
@radeksimko That is what I did at the first try :) But I didn't come up with a good name for that. Do you have any suggestion about the naming? |
@radeksimko A kindly ping, would you mind provide a suitable name for the new source? |
@magodo I already proposed the new name in my original comment 😉
|
@radeksimko Ah, sorry 🙈. I've made a new commit to implement the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I left you an in-line comment regarding the tests - otherwise the implementation LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good, I just left one suggestion, effectively re-enabling the test. Aside from that I think you may need to rebase your branch, to bring in #57
Then once tests are passing I'm happy to approve and merge.
@radeksimko I've updated the test and merged with main branch. The test is passing now: ❯ E2E_TESTING=1 go test -v -run="^TestVersion$" ./...
=== RUN TestVersion
--- PASS: TestVersion (7.79s)
PASS
ok github.com/hashicorp/hc-install/fs 7.795s |
fs.AnyVersion
supports optional version constraintfs.Version
to support version constraint
fs.Version
to support version constraintfs.Version
to support version constrained binary discovery
Allows users to optionally specify one or more (comma separated) version constraints for
fs.AnyVersion
source.