Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support releases-api returned content-type #57

Merged
merged 3 commits into from May 10, 2022

Conversation

smacfarlane
Copy link
Contributor

@smacfarlane smacfarlane commented May 9, 2022

Update the content-type checks to include the type returned from the releases api.

Edit: Also set Go version to 1.18 when building Consul from source.

Closes #56

Signed-off-by: Scott Macfarlane smacfarlane@hashicorp.com

Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>
@smacfarlane smacfarlane requested a review from radeksimko May 9, 2022
Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>
Copy link
Member

@radeksimko radeksimko left a comment

Thanks for the fix and also for fixing the Consul build.

Regarding Consul, I have filed #58 and for the header issue we also have #9

@radeksimko radeksimko merged commit ba20d15 into main May 10, 2022
5 checks passed
@radeksimko radeksimko deleted the sm/releases-api-content-type branch May 10, 2022
shoenig pushed a commit to shoenig/hc-install that referenced this pull request May 10, 2022
* Support releases-api returned content-type

Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>

* Set Go to v1.18 when building consul from source

Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>

* remove unused variables

Co-authored-by: Radek Simko <radek.simko@gmail.com>
shoenig added a commit to shoenig/hc-install that referenced this pull request May 10, 2022
Support releases-api returned content-type (hashicorp#57)
inkel added a commit to grafana/terraform-provider-grafana that referenced this pull request May 12, 2022
This package is responsible for installing Terraform to perform
acceptance tests. Since the announcement of the HashiCorp Releases API
[1] 3 days ago our CI is broken. After further inspection, I've found
that this package was indeed the culprit, and that we need to upgrade
the package to 0.3.2 after
hashicorp/hc-install#57 got merged.

1: https://www.hashicorp.com/blog/announcing-the-hashicorp-releases-api
inkel added a commit to grafana/terraform-provider-grafana that referenced this pull request May 12, 2022
* Upgrade indirect hc-install package

This package is responsible for installing Terraform to perform
acceptance tests. Since the announcement of the HashiCorp Releases API
[1] 3 days ago our CI is broken. After further inspection, I've found
that this package was indeed the culprit, and that we need to upgrade
the package to 0.3.2 after
hashicorp/hc-install#57 got merged.

1: https://www.hashicorp.com/blog/announcing-the-hashicorp-releases-api

* Use version 1.45 of golangci-lint and not latest

Version 1.46+ throws a bunch of errors that doesn't really stop this from working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install failure with content-type mismatch
2 participants