Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update crypto dependency for macOS support #522

Merged
merged 1 commit into from May 20, 2022

Conversation

shoenig
Copy link
Contributor

@shoenig shoenig commented Apr 4, 2022

I think this just applies to recent versions of macOS,
but hclfmt cannot be installed with the transitive dependency on
golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82
caused by the dependency on golang.org/x/crypto.

Update the crypto library so that a newer version of sys gets pulled in,
which compiles fine.

➜ uname -v
Darwin Kernel Version 21.4.0: Fri Mar 18 00:47:26 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T8101

➜ git rev-parse HEAD
8c86d68fd91a93c353e1fd5c8622f527523307db

➜ go install
# golang.org/x/sys/unix
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:28:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:43:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:59:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:75:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:90:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:105:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:121:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:136:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:151:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:166:3: //go:linkname must refer to declared function or variable
../../../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82/unix/zsyscall_darwin_arm64.go:166:3: too many errorsqgit

Copy link
Member

@jbardin jbardin left a comment

I think there have been a few more x/crypto commits since this was made, so we probably want to fetch @latest once more.

Not sure if this is M1 specific or just newer versions of macOS altogether,
but hclfmt cannot be installed with the transitive dependency on
`golang.org/x/sys@v0.0.0-20190502175342-a43fa875dd82`
caused by the dependency on `golang.org/x/crypto`.

Update the crypto library so that a newer version of sys gets pulled in,
which compiles fine.
@shoenig shoenig force-pushed the update-deps-for-macos branch from 3482806 to 8927e75 Compare May 17, 2022
@shoenig
Copy link
Contributor Author

shoenig commented May 17, 2022

Updated again @jbardin

-       golang.org/x/crypto v0.0.0-20220331220935-ae2d96664a29
+       golang.org/x/crypto v0.0.0-20220517005047-85d78b3ac167

@shoenig shoenig merged commit d0c4fa8 into main May 20, 2022
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants