From 021cdbe0e60870f9bb0adcaaa34a501e057d90f6 Mon Sep 17 00:00:00 2001 From: James Rasell Date: Sat, 21 Jul 2018 09:09:22 +0100 Subject: [PATCH] Do not fail a deployment when nodes have been filtered during eval. Previously if an eval included information about filtered nodes the deployment would show as failed even if the non-filtered evals placed successfully. This change means Levant will not fail when evals are filtered and will continue to track the rest of the deployment. Closes #220 --- levant/deploy.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/levant/deploy.go b/levant/deploy.go index c8afb653d..e7b4f2779 100644 --- a/levant/deploy.go +++ b/levant/deploy.go @@ -254,8 +254,10 @@ func (l *levantDeployment) evaluationInspector(evalID *string) error { } } - return fmt.Errorf("evaluation %v finished with status %s but failed to place allocations", - *evalID, evalInfo.Status) + // Do not return an error here; there could well be information from + // Nomad detailing filtered nodes but the deployment will still be + // successful. GH-220. + return nil default: time.Sleep(1 * time.Second)