Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv6 parsing in resolveAddr doesn't handle the case where the port is missing #63

Closed
slackpad opened this issue Dec 19, 2015 · 2 comments
Closed

IPv6 parsing in resolveAddr doesn't handle the case where the port is missing #63

slackpad opened this issue Dec 19, 2015 · 2 comments
Labels
bug

Comments

@slackpad
Copy link
Contributor

This came out of hashicorp/serf#286 but the problem is down in memberlist. Behavior may have varied across Go versions, but with 1.5.2 if you don't supply a port number then it will try to lookup the address via DNS. Adding the port number does the right thing.

We should fix the support for IPV6 addresses without port numbers inresolveAddr().
@slackpad slackpad added the bug label Dec 19, 2015
@orivej orivej mentioned this issue Mar 5, 2016
Merged
@meyskens
Copy link
Contributor

I was looking into moby/moby#33398 which seems to be an issue in memberlist rather than moby. Seeing the PR is this fixed or not?

@slackpad
Copy link
Contributor Author

Hi @meyskens this should have been closed with #69. Thanks for adding the additional test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slackpad @meyskens