Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn on invalid Docker network_mode for Connect #10725

Open
tgross opened this issue Jun 8, 2021 · 1 comment
Open

warn on invalid Docker network_mode for Connect #10725

tgross opened this issue Jun 8, 2021 · 1 comment

Comments

@tgross
Copy link
Member

tgross commented Jun 8, 2021

A docker task with with Connect enabled has its network_mode implicitly set to container:<name of pause container> and users should not set the network_mode manually or their task will be in a different network namespace from Envoy. This is documented in #10724.

We should also have the Nomad client warn the user against doing this. We might not want to try to make it an error, as there may be some edge cases I haven't considered here. (Ex. can the sidecar_task have an explicit network_mode?)

@tgross
Copy link
Member Author

tgross commented Jun 16, 2021

This also impacts task-to-task network communication over localhost in general. The more I'm looking at this, I'm not sure it's ever a good idea to allow setting network_mode = "bridge" here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant