Prometheus dashboard #3186
Merged
Prometheus dashboard #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelseakomlo
force-pushed
the
f-prometheus-dashboard
branch
2 times, most recently
from
c2a797a
to
c262d9d
Compare
Merged
chelseakomlo
force-pushed
the
f-prometheus-dashboard
branch
3 times, most recently
from
50635e2
to
6fd3ebc
Compare
chelseakomlo
force-pushed
the
f-prometheus-dashboard
branch
from
6fd3ebc
to
66c0df7
Compare
dadgar
requested changes
Sep 14, 2017
CHANGELOG.md
Outdated
|
|
||
| BUG FIXES: | ||
| * core: *Fix restoration of stopped periodic jobs [GH-3201] | ||
| * api: Fix search handling of jobs with more than four hyphens and case were |
There was a problem hiding this comment.
Can you fix the star above ^
integrations/prometheus/README.md
Outdated
| - See Prometheus's | ||
| [Getting Started](https://prometheus.io/docs/introduction/getting_started/) | ||
| guide for instructions on how to set up a Prometheus server. | ||
| - A running Consul server, which will need to be added to this configuration |
There was a problem hiding this comment.
Can you clarify this point. I think you may want to say that the configuration is setup to read from the local agent and thus if the prometheus server is run on a machine without a Consul agent, the configuration will have to be updated to point to a Consul server.
| @@ -0,0 +1,22 @@ | |||
| global: | |||
| external_labels: | |||
| metrics_path: /v1/metrics | ||
| params: | ||
| format: ['prometheus'] | ||
|
|
| monitor: 'codelab-monitor' | ||
|
|
||
| scrape_configs: | ||
| - job_name: 'nomad_data' |
chelseakomlo
force-pushed
the
f-prometheus-dashboard
branch
from
e00222e
to
b04a476
Compare
chelseakomlo
force-pushed
the
f-prometheus-dashboard
branch
from
b04a476
to
3a8320c
Compare
dadgar
approved these changes
Sep 15, 2017
integrations/prometheus/README.md
Outdated
| - See Prometheus's | ||
| [Getting Started](https://prometheus.io/docs/introduction/getting_started/) | ||
| guide for instructions on how to set up a Prometheus server. | ||
| - A running Consul server. This configuration is written for a local remote |
There was a problem hiding this comment.
local remote?
This configuration is written assuming there is a local Consul agent being run along side the Prometheus server. If this is not the case, the configuration will need to be updated to point at the remote Consul agent.
d13c0d9
to
e7933df
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates example prometheus configuration files and dashboards for Nomad.
This should be merged after #3171