Upgrade hcl2 to validate arrays for unknown values #5844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2019 12:25
This upgrades hcl2 library dependency to pick up hashicorp/hcl2#113 . Prior to this change, parsing and decoding array attributes containing invalid errors (e.g. references to unknown variables) are silently dropped, with `cty.Unknown` being assigned to the bad element. Rather than showing a type/meaningful error from hcl2, we get a very decrypted error message from msgpack layer trying to handle `cty.unknown`. This ensures that we propagate diagnostics correctly and report meaningful errors to users. Fixes #5694 Fixes #5680
preetapan
approved these changes
Jun 19, 2019
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades hcl2 library dependency to pick up
hashicorp/hcl2#113 .
Prior to this change, parsing and decoding array attributes containing
invalid errors (e.g. references to unknown variables) are silently
dropped, with
cty.Unknownbeing assigned to the bad element.Rather than showing a type/meaningful error from hcl2, we get a very cryptic error message from msgpack layer trying to handle
cty.unknown. Sometimes, we do get an hcl type validation error back, but it's still cryptic e.g.Incorrect attribute value type; Inappropriate value for attribute "list_field": map of string requiredwithout explaining why it's inappropriate.This ensures that we propagate diagnostics correctly and report
meaningful errors to users.
The tests capture the behavior, you can see the failing tests in https://travis-ci.org/hashicorp/nomad/jobs/546843716 and they pass in the latest commit of this PR: https://travis-ci.org/hashicorp/nomad/jobs/546848034 .
Fixes #5694
Fixes #5680