Skip to content

feat: Add -task to alloc logs command#10026

Merged
drewbailey merged 1 commit into
hashicorp:masterfrom
mr-karan:feat/alloc-logs
Feb 16, 2021
Merged

feat: Add -task to alloc logs command#10026
drewbailey merged 1 commit into
hashicorp:masterfrom
mr-karan:feat/alloc-logs

Conversation

@mr-karan

Copy link
Copy Markdown
Contributor

Fixes #8450

Please review @drewbailey !

Comment thread command/alloc_logs.go Outdated
Comment thread command/alloc_logs.go Outdated

@drewbailey drewbailey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr-karan Thanks for taking this on, looks good! Just two minor suggestions

@drewbailey drewbailey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mr-karan

Copy link
Copy Markdown
Contributor Author

@drewbailey updated.

@drewbailey drewbailey merged commit f159903 into hashicorp:master Feb 16, 2021
@drewbailey drewbailey mentioned this pull request Feb 16, 2021
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align ux across nomad alloc sub commands

3 participants