Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use max-width to ensure the width rule is observed in Firefox #6466

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@DingoEatingFuzz
Copy link
Contributor

DingoEatingFuzz commented Oct 10, 2019

Fixes #6098 This time for Firefox.

image

@DingoEatingFuzz DingoEatingFuzz requested a review from hashicorp/frontend Oct 10, 2019
Copy link
Contributor

johncowen left a comment

Oh man, killer! Well done in getting it sorted!

LGTM!

@shantanugadgil

This comment has been minimized.

Copy link
Contributor

shantanugadgil commented Oct 11, 2019

Awesome!!! 🍺 I use Firefox as much as possible and Vivaldi. I don't even install Chrome anywhere. This will be a big help!!!

EDIT: rc1 refresh? or rc2? 😉

@johncowen johncowen added the ui label Oct 11, 2019
@DingoEatingFuzz DingoEatingFuzz merged commit 53400c5 into master Oct 15, 2019
40 checks passed
40 checks passed
ci/circleci: test-ui Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
license/snyk - scripts/screenshots/src/package.json (Security Team) No manifest changes detected
license/snyk - ui/lib/bulma/package.json (Security Team) No manifest changes detected
license/snyk - ui/package.json (Security Team) No manifest changes detected
license/snyk - vendor/github.com/circonus-labs/circonus-gometrics/Gopkg.lock (Security Team) No manifest changes detected
license/snyk - vendor/github.com/fatih/color/Gopkg.lock (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/aliyun/vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/aws/vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/azure/vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/digitalocean/vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/gce/vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/os/vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/scaleway/vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/softlayer/vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/triton/vendor/github.com/joyent/triton-go/Gopkg.lock (Security Team) No manifest changes detected
license/snyk - vendor/github.com/hashicorp/go-discover/provider/triton/vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - vendor/go.opencensus.io/Gopkg.lock (Security Team) No manifest changes detected
license/snyk - vendor/vendor.json (Security Team) No manifest changes detected
license/snyk - website/Gemfile.lock (Security Team) No manifest changes detected
netlify/nomad-ui/deploy-preview UI deployment succeeded
Details
netlify/nomad-website/deploy-preview website deployment succeeded
Details
security/snyk - scripts/screenshots/src/package.json (Security Team) No manifest changes detected
security/snyk - ui/lib/bulma/package.json (Security Team) No manifest changes detected
security/snyk - ui/package.json (Security Team) No manifest changes detected
security/snyk - vendor/github.com/circonus-labs/circonus-gometrics/Gopkg.lock (Security Team) No manifest changes detected
security/snyk - vendor/github.com/fatih/color/Gopkg.lock (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/aliyun/vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/aws/vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/azure/vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/digitalocean/vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/gce/vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/os/vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/scaleway/vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/softlayer/vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/triton/vendor/github.com/joyent/triton-go/Gopkg.lock (Security Team) No manifest changes detected
security/snyk - vendor/github.com/hashicorp/go-discover/provider/triton/vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - vendor/go.opencensus.io/Gopkg.lock (Security Team) No manifest changes detected
security/snyk - vendor/vendor.json (Security Team) No manifest changes detected
security/snyk - website/Gemfile.lock (Security Team) No manifest changes detected
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui-firefox-log-window-off-screen branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.