tr/service_hook: prevent Update from running before Poststart finish #7600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shout out to @42wim for doing the leg work to track down this bug 🎉 |
notnoop
reviewed
Apr 2, 2020
| ) | ||
|
|
||
| // Statically assert the stats hook implements the expected interfaces | ||
| var _ interfaces.TaskPoststartHook = (*serviceHook)(nil) | ||
| var _ interfaces.TaskExitedHook = (*serviceHook)(nil) | ||
| var _ interfaces.TaskPreKillHook = (*serviceHook)(nil) | ||
| var _ interfaces.TaskUpdateHook = (*serviceHook)(nil) | ||
|
|
||
| func TestUpdate_beforePoststart(t *testing.T) { |
notnoop
approved these changes
Apr 2, 2020
| @@ -164,6 +173,7 @@ func (h *serviceHook) Exited(context.Context, *interfaces.TaskExitedRequest, *in | |||
| h.mu.Lock() | |||
| defer h.mu.Unlock() | |||
| h.deregister() | |||
| h.initialRegistration = false | |||
There was a problem hiding this comment.
Also, in Stop() or move to deregister?
| require.NoError(t, hook.Poststart(context.Background(), &interfaces.TaskPoststartRequest{}, &interfaces.TaskPoststartResponse{})) | ||
| require.Len(t, c.GetOps(), 5) | ||
| require.NoError(t, hook.Update(context.Background(), &interfaces.TaskUpdateRequest{Alloc: alloc}, &interfaces.TaskUpdateResponse{})) | ||
| require.Len(t, c.GetOps(), 6) |
There was a problem hiding this comment.
Maybe also test PreKilled then update after the last update?
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service hook requires fields initialized during Poststart when executing other lifecycle functions. In particular Update can be called at any time including before Poststart. This manifests as an error because the driver network information has not been set yet.
fixes #5767