connect: enable configuring sidecar_task.name #7684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the submitted jobspec for
sidecar_task
would passthrough 2 HCL key validation steps - once for the subset specific
to connect sidecar task definitions, and once again for the set
of normal task definition.
The valid keys for the normal task definition did not include
name
, which is supposed to be configurable for the sidecartask. To fix this, just eliminate the double validation for sidecars,
and instead pass in the correct set of keys to validate against
to the one generic task parser.
Fixes #7680
Example)