Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support S3 and AMI encryption in amazon-import post-processor #7396

Merged
merged 1 commit into from Mar 25, 2019

Conversation

@c0sco
Copy link
Contributor

@c0sco c0sco commented Mar 11, 2019

This adds support to the amazon-import post-processor for encryption to both the S3 artifact and the resulting AMI. It allows for encryption in S3 with KMS or AES256, and the resulting AMI using KMS. It doesn't support an 'SSE-C' customer supplied AES key for S3 as the VM import service doesn't have support for this (despite a lack of documentation on this). I have a ticket open with AWS to clarify their documentation around SSE-C and VM import. If AWS adds support for this in the future it will be easy to add to this code.

This adds 4 new config parameters as described in the updated documentation.

Output of various test runs at https://gist.github.com/c0sco/084f0407512c236dfdf0118e9f209e9e

Closes #4788

@c0sco c0sco requested a review from hashicorp/packer as a code owner Mar 11, 2019
@hashicorp-cla
Copy link

@hashicorp-cla hashicorp-cla commented Mar 11, 2019

CLA assistant check
All committers have signed the CLA.

@c0sco
Copy link
Contributor Author

@c0sco c0sco commented Mar 13, 2019

I think I'll need some assistance with this as the CI tests have failed, but the failure doesn't seem to be related to my changes. When I run "make ci" locally everything passes.

@SwampDragons
Copy link
Member

@SwampDragons SwampDragons commented Mar 15, 2019

Kicked the build. Sometimes the long uploads are flaky; I need to take a look at what's going on in Travis but it wasn't you.

Copy link
Member

@SwampDragons SwampDragons left a comment

This is great :)

@SwampDragons SwampDragons merged commit 2c67cd9 into hashicorp:master Mar 25, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@SwampDragons
Copy link
Member

@SwampDragons SwampDragons commented Mar 25, 2019

Sorry for taking so long to review; this is great.

@c0sco
Copy link
Contributor Author

@c0sco c0sco commented Mar 26, 2019

Thank you!

@SwampDragons SwampDragons added this to the v1.4.0 milestone Mar 26, 2019
@ghost
Copy link

@ghost ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days . This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants