Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible 2.7 "use_tty" fix #7461

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@Liath
Copy link
Contributor

Liath commented Apr 3, 2019

Per Issue #6453, Ansible@2.7 targetting Windows was throwing the following error when setup as the docs instruct:
"Requested option use_tty was not defined in configuration"

This is caused by something in Ansible silently discarding the whole DOCUMENTATION string configuration when it can't parse it. The changed line in this PR fixes that. :)

I tested Ansible 2.3.2, 2.4, 2.5, and 2.7.9 all work when using the ssh plugin doc string from Ansible 2.7. So I think the following are correct:

Closes: #4904
Closes: #6453

It should probably also be documented that if you are using Ansible 2.3 you need to be on at least 2.3.2.

Ansible 2,7 "use_tty" fix
Per Issue #6453, Ansible@2.7 targetting Windows was throwing the following error when setup as the docs instruct:
"Requested option use_tty was not defined in configuration"

This is caused by something in Ansible silently discarding the whole `DOCUMENTATION` string configuration when it can't parse it. The changed line in this PR fixes that. :)

@Liath Liath requested a review from hashicorp/packer as a code owner Apr 3, 2019

@hashicorp-cla

This comment has been minimized.

Copy link

hashicorp-cla commented Apr 3, 2019

CLA assistant check
All committers have signed the CLA.

@SwampDragons
Copy link
Member

SwampDragons left a comment

Awesome catch!

@SwampDragons SwampDragons merged commit fd01738 into hashicorp:master Apr 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@SwampDragons SwampDragons added this to the v1.4.0 milestone Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.