Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMerge the vSphere builder #8480
Conversation
* Simple linked cloning, just crashing if no snapshots
* Added conversion to template without timeout * Added timeout * Extracted converting to template to a separate step
Tests
This comment has been minimized.
This comment has been minimized.
|
Thanks for opening this! |
This comment has been minimized.
This comment has been minimized.
|
2 signatures to go |
This comment has been minimized.
This comment has been minimized.
|
@remijouannet, @scbjans; sorry for pinging you, we only need you two to sign the cla so that your work can be incorporated into Packer How does that sound to you ? |
This comment has been minimized.
This comment has been minimized.
|
hello, CLA sign |
This comment has been minimized.
This comment has been minimized.
|
Thanks so much for signing the CLA, folks! I'll take it from here. |
This comment has been minimized.
This comment has been minimized.
|
@SwampDragons , If you need for your tests , I can give you access to a vSphere. |
This comment has been minimized.
This comment has been minimized.
|
Thanks, I'm working on getting some set up internally, just takes a bit of time :D |
This comment has been minimized.
This comment has been minimized.
|
Plus, normally we don't run acceptance tests on every PR, just on releases. So I'll be reworking the organization a bit. |
… testing logic; disable acceptance tests (for now) until we can set up a test rig inside of HashiCorp. Regenerate code based on vendoring changes.
|
Nice one ! There are some minor hcl2 related tweaks; other than that LGTM |
| func (b *Builder) ConfigSpec() hcldec.ObjectSpec { return b.config.FlatMapstructure().HCL2Spec() } | ||
|
|
||
| func (b *Builder) Prepare(raws ...interface{}) ([]string, []string, error) { | ||
| c, warnings, errs := NewConfig(raws...) |
This comment has been minimized.
This comment has been minimized.
azr
Jan 10, 2020
Member
Watch out; this needs to change to
| c, warnings, errs := NewConfig(raws...) | |
| warnings, errs := b.config.Prepare(raws...) |
Because the HCL2 code will cause prepare to be called twice. Once when starting the builder and one in packer core.
| ) | ||
|
|
||
| type Builder struct { | ||
| config *Config |
This comment has been minimized.
This comment has been minimized.
|
|
||
| func (b *Builder) Run(ctx context.Context, ui packer.Ui, hook packer.Hook) (packer.Artifact, error) { | ||
| state := new(multistep.BasicStateBag) | ||
| state.Put("comm", &b.config.Comm) |
This comment has been minimized.
This comment has been minimized.
|
|
||
| func (b *Builder) Run(ctx context.Context, ui packer.Ui, hook packer.Hook) (packer.Artifact, error) { | ||
| state := new(multistep.BasicStateBag) | ||
| state.Put("comm", &b.config.Comm) |
This comment has been minimized.
This comment has been minimized.
| func (b *Builder) ConfigSpec() hcldec.ObjectSpec { return b.config.FlatMapstructure().HCL2Spec() } | ||
|
|
||
| func (b *Builder) Prepare(raws ...interface{}) ([]string, []string, error) { | ||
| c, warnings, errs := NewConfig(raws...) |
This comment has been minimized.
This comment has been minimized.
azr
Jan 10, 2020
Member
| c, warnings, errs := NewConfig(raws...) | |
| warnings, errs := b.config.Prepare(raws...) |
| ) | ||
|
|
||
| type Builder struct { | ||
| config *Config |
This comment has been minimized.
This comment has been minimized.
| @@ -0,0 +1,20 @@ | |||
| <component name="ProjectDictionaryState"> | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Yaaaaay |
randomcamel commentedDec 10, 2019
•
edited by SwampDragons
This is to merge the vSphere builder written
by JetBrains and others.
Closes #8532
Closes #4526