Buffer applyCh to size MaxAppendEntries #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Actually, I'll just try to fix the race condition here by using a context and done channel, as suggested |
api.go
Outdated
| @@ -498,7 +499,7 @@ func NewRaft(conf *Config, fsm FSM, logs LogStore, stable StableStore, snaps Sna | |||
| // Create Raft struct. | |||
| r := &Raft{ | |||
| protocolVersion: protocolVersion, | |||
| applyCh: make(chan *logFuture), | |||
| applyCh: make(chan *logFuture, conf.ApplyChSize), | |||
There was a problem hiding this comment.
Should this now just be conf.MaxAppendEntries given that it will at most pull that many off the channel.
alecjen
changed the title
alecjen
force-pushed
the
configurable_applych
branch
from
7b22bfa
to
d58cb41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the solution suggested in #124 to enable batch processing off the raft applyCh
For context, our application uses this library, and we are currently bottlenecked by StoreLogs throughput. We believe we can boost this throughput by increasing batch size in StoreLogs, which fsync's on each call.
Appreciate all the help team 馃挴