From 775909ca57bb7b82b1bc9f5205a6292a44db4df7 Mon Sep 17 00:00:00 2001 From: Pamela Bortnick Date: Thu, 6 Oct 2022 13:20:19 -0400 Subject: [PATCH 1/2] Edit subnav styles to center nav links always --- packages/subnav/docs.mdx | 10 ++++++++++ packages/subnav/index.js | 1 + packages/subnav/partials/CtaLinks/style.module.css | 2 +- packages/subnav/style.module.css | 7 ++++++- 4 files changed, 18 insertions(+), 2 deletions(-) diff --git a/packages/subnav/docs.mdx b/packages/subnav/docs.mdx index f305afb3d..c4ad9b85a 100644 --- a/packages/subnav/docs.mdx +++ b/packages/subnav/docs.mdx @@ -18,6 +18,16 @@ Displays a navigation bar, with links and a call-to-action. Links can be organiz />`} +## Without CTA: + + ### Props diff --git a/packages/subnav/index.js b/packages/subnav/index.js index 214db7c32..d9c05851e 100644 --- a/packages/subnav/index.js +++ b/packages/subnav/index.js @@ -70,6 +70,7 @@ function SubnavInner({
diff --git a/packages/subnav/partials/CtaLinks/style.module.css b/packages/subnav/partials/CtaLinks/style.module.css index 6f26b2655..d76fa06f0 100644 --- a/packages/subnav/partials/CtaLinks/style.module.css +++ b/packages/subnav/partials/CtaLinks/style.module.css @@ -1,7 +1,7 @@ .root { align-items: center; display: flex; - justify-content: center; + justify-content: flex-end; white-space: nowrap; & > * + * { diff --git a/packages/subnav/style.module.css b/packages/subnav/style.module.css index 34e6a4a4d..bac8e3dcc 100644 --- a/packages/subnav/style.module.css +++ b/packages/subnav/style.module.css @@ -36,10 +36,15 @@ } .subnavInner { - display: flex; + display: grid; + grid-template-columns: 1fr 2fr 1fr; align-items: center; height: 62px; + &.hasOverflow { + display: flex; + } + &.notConstrained { padding: 0 24px; From df426f9bf17b7a3374fe2649ffb1990d8db3bcb2 Mon Sep 17 00:00:00 2001 From: Pamela Bortnick Date: Thu, 6 Oct 2022 13:25:40 -0400 Subject: [PATCH 2/2] Create popular-news-cough.md --- .changeset/popular-news-cough.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/popular-news-cough.md diff --git a/.changeset/popular-news-cough.md b/.changeset/popular-news-cough.md new file mode 100644 index 000000000..014dc9448 --- /dev/null +++ b/.changeset/popular-news-cough.md @@ -0,0 +1,5 @@ +--- +"@hashicorp/react-subnav": patch +--- + +Ensure subnav link items are centered when there is no overflow