Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove @reach/auto-id dep, opt for react's useId #989

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

kendallstrautman
Copy link
Contributor

@kendallstrautman kendallstrautman commented Aug 1, 2023

🎟️ Asana Task
πŸ” Preview Link


Description

@reach/auto-id is pinned <= react 17 and this dependency causes conflicts / warnings where react 18 is used. This refactors all uses of @reach/auto-id to use the react version.

Screenshot 2023-08-01 at 9 04 25 AM

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2023

πŸ¦‹ Changeset detected

Latest commit: 0f75c91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hashicorp/react-checkbox-input Major
@hashicorp/react-text-input Major
@hashicorp/react-textarea-input Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 1, 2023 4:52pm

Copy link
Contributor

@thiskevinwang thiskevinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to bump peerDependencies.react in each of the package.jsons to >=18.x since useId is only available in 18+

@kendallstrautman
Copy link
Contributor Author

@thiskevinwang Ah yes πŸ‘ Are all of our repos that use these packages using react 18? Would that update be an issue?

@dstaley
Copy link
Contributor

dstaley commented Aug 1, 2023

I think Dev Portal the challenge is the only repo using these packages, so it should be safe to update!

@kendallstrautman kendallstrautman merged commit 1338cdc into main Aug 2, 2023
5 checks passed
@kendallstrautman kendallstrautman deleted the ks.update-use-id branch August 2, 2023 19:10
@hashibot-web hashibot-web mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants