-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove @reach/auto-id dep, opt for react's useId
#989
Conversation
π¦ Changeset detectedLatest commit: 0f75c91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to bump peerDependencies.react
in each of the package.json
s to >=18.x
since useId
is only available in 18+
@thiskevinwang Ah yes π Are all of our repos that use these packages using react 18? Would that update be an issue? |
I think |
ποΈ Asana Task
π Preview Link
Description
@reach/auto-id
is pinned <= react 17 and this dependency causes conflicts / warnings where react 18 is used. This refactors all uses of@reach/auto-id
to use the react version.PR Checklist π
Items in this checklist may not may not apply to your PR, but please consider each item carefully.