Fix ToObjectValue function for nested objects for null or unknown value states
#138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
reviewed
May 14, 2024
internal/schema/templates/nested_object_value_to_object_value.gotmpl
Outdated
Show resolved
Hide resolved
austinvalle
added
enhancement
ansgarm
commented
May 14, 2024
…alue states Previously the generated code would still return data in these two cases making it impossible to leave out configuration for optional attributes that contained required fields within.
ansgarm
force-pushed
the
fix-null-unknown-object-values
branch
from
0c9d8f7 to
83d5ebf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the generated code would still return data in these two cases making it
impossible to leave out configuration for optional attributes that contained required
fields within.