Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error if data source or resource not found in schemas #151

Merged
merged 6 commits into from Jun 14, 2022

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Jun 14, 2022

The changes present in v0.10.0 result in an error being generated if providerShortName or providerShortName concatenated with the template filename (following stripping of file extensions) are not found in the data source or resource schemas.

This PR reinstates the behaviour present in v0.9.0, where the failure to find the schema does not result in an error.

@bendbennett bendbennett requested a review from a team as a code owner Jun 14, 2022
internal/provider/generate.go Outdated Show resolved Hide resolved
internal/provider/generate.go Outdated Show resolved Hide resolved
bendbennett and others added 2 commits Jun 14, 2022
Co-authored-by: Ivan De Marino <ivan.demarino@hashicorp.com>
Co-authored-by: Ivan De Marino <ivan.demarino@hashicorp.com>
detro
detro previously approved these changes Jun 14, 2022
detro
detro approved these changes Jun 14, 2022
@bendbennett bendbennett merged commit 70c0afc into main Jun 14, 2022
4 checks passed
@bendbennett bendbennett deleted the bendbennett/no-error-on-schema-not-found branch Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants