Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Introduce logging unit testing #316

Merged
merged 1 commit into from May 5, 2022
Merged

internal: Introduce logging unit testing #316

merged 1 commit into from May 5, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented May 4, 2022

Creates internal/testing/emptyprovider package so it can be shared for multiple packages, then uses it to verify the logging setup with (internal/proto6server.Server).GetProviderSchema(). This could be expanded to other RPC handlers, if desired and the testing setup is trivial enough. Also added unit testing within internal/logging to ensure it is fully covered.

Creates internal/testing/emptyprovider so it can be shared for multiple packages, then uses it to verify the logging setup with `(internal/proto6server.Server).GetProviderSchema()`. This could be expanded to other RPC handlers, if desired and the testing setup is trivial enough. Also added unit testing within internal/logging to ensure it is fully covered.
@bflad bflad added the tech-debt label May 4, 2022
@bflad bflad added this to the v0.8.0 milestone May 4, 2022
@bflad bflad requested a review from as a code owner May 4, 2022
Copy link
Contributor

@bendbennett bendbennett left a comment

LGTM

detro
detro approved these changes May 5, 2022
@bflad bflad merged commit 2abaedc into main May 5, 2022
6 checks passed
@bflad bflad deleted the bflad-logging-testing branch May 5, 2022
@github-actions
Copy link

@github-actions github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days . This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech-debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants