Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Require Metadata method for Provider interface #580

Merged
merged 3 commits into from Dec 13, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Dec 13, 2022

To remove potential confusion about optionally specifying this information. In the future, the provider metadata can be expanded further for documentation generation purposes.

@bflad bflad added the breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. label Dec 13, 2022
@bflad bflad added this to the v1.0.0 milestone Dec 13, 2022
@bflad bflad requested a review from a team as a code owner December 13, 2022 15:10
@bflad bflad force-pushed the bflad/provider-Metadata-required branch from 058c087 to 1ddeb55 Compare December 13, 2022 15:18
To remove potential confusion about optionally specifying this information. In the future, the provider metadata can be expanded further for documentation generation purposes.
@bflad bflad force-pushed the bflad/provider-Metadata-required branch from 1ddeb55 to 8434065 Compare December 13, 2022 15:21
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 13ceef9 into main Dec 13, 2022
16 checks passed
@bflad bflad deleted the bflad/provider-Metadata-required branch December 13, 2022 18:51
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants