Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer using raw fixtures in testing #74

Merged
merged 4 commits into from Jul 13, 2022

Conversation

detro
Copy link
Contributor

@detro detro commented Jul 13, 2022

This contains changes originally contained in #71: it was extracted to reduce the surface-area of the review.

Ivan De Marino added 3 commits Jul 13, 2022
This is to avoid any side-effect from changes that are outside the immediate domain of this library
@detro detro requested a review from a team as a code owner Jul 13, 2022
@detro detro mentioned this pull request Jul 13, 2022
4 tasks
@detro detro added this to the v0.5.0 milestone Jul 13, 2022
bflad
bflad approved these changes Jul 13, 2022
Copy link
Member

@bflad bflad left a comment

Looks good to me 🚀

@detro detro merged commit 0f9eafb into main Jul 13, 2022
4 checks passed
@detro detro deleted the detro/prefer_using_raw_fixtures_in_testing branch Jul 13, 2022
@github-actions
Copy link

github-actions bot commented Aug 13, 2022

I'm going to lock this pull request because it has been closed for 30 days . This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants