Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SDKv2/logging documentation section #1011

Merged
merged 5 commits into from Jul 28, 2022

Conversation

detro
Copy link
Contributor

@detro detro commented Jul 27, 2022

This includes a dedicated page to the new NewLoggingHTTPTransport() and NewSubsystemLoggingHTTPTransport() helpers, introduced in #1006.

Closes #1007

@detro detro requested a review from a team as a code owner Jul 27, 2022
@detro detro added this to the v2.20.0 milestone Jul 27, 2022
Copy link
Contributor

@laurapacilio laurapacilio left a comment

I'm going to approve so I don't block this work, but I had a few questions and suggestions for you here. Overall, really great work - I think this will be very helpful for users!

Please push back on me where I've materially changed the meaning or misunderstood what's happening. Thank you for the chance to comment on this! :-)

website/docs/plugin/sdkv2/logging/index.mdx Outdated Show resolved Hide resolved
website/docs/plugin/sdkv2/logging/index.mdx Outdated Show resolved Hide resolved
website/docs/plugin/sdkv2/logging/index.mdx Outdated Show resolved Hide resolved
website/docs/plugin/sdkv2/logging/index.mdx Outdated Show resolved Hide resolved
website/docs/plugin/sdkv2/logging/http-transport.mdx Outdated Show resolved Hide resolved
website/docs/plugin/sdkv2/logging/http-transport.mdx Outdated Show resolved Hide resolved
website/docs/plugin/sdkv2/logging/http-transport.mdx Outdated Show resolved Hide resolved
website/docs/plugin/sdkv2/logging/http-transport.mdx Outdated Show resolved Hide resolved
website/docs/plugin/sdkv2/logging/http-transport.mdx Outdated Show resolved Hide resolved
website/docs/plugin/sdkv2/logging/http-transport.mdx Outdated Show resolved Hide resolved
detro and others added 5 commits Jul 28, 2022
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
@detro detro force-pushed the detro/1007-document_new-logging-http-transport branch from 20f6b8d to afe1761 Compare Jul 28, 2022
@detro detro merged commit 92520a9 into main Jul 28, 2022
1 check passed
@detro detro deleted the detro/1007-document_new-logging-http-transport branch Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Aug 28, 2022

I'm going to lock this pull request because it has been closed for 30 days . This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the new NewLoggingHTTPTransport and NewSubsystemLoggingHTTPTransport
2 participants