Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/resource: Check for existing provider configuration block in TestStep merged configuration #1092

Merged
merged 2 commits into from Nov 14, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Nov 8, 2022

Closes #1064

Previously:

    --- FAIL: TestStepMergedConfig/teststep-externalproviders-config-with-provider-block-unquoted (0.00s)
        /Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/teststep_providers_test.go:643: unexpected difference:   (
              	"""
              	... // 6 identical lines
              	  }
              	}
            - 
            - 	provider "test" {}
            - 
              
              	provider test {}
              	... // 2 identical lines
              	"""
              )
    --- FAIL: TestStepMergedConfig/teststep-externalproviders-config-with-provider-block-quoted (0.00s)
        /Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/teststep_providers_test.go:643: unexpected difference:   (
              	"""
              	... // 6 identical lines
              	  }
              	}
            - 
            - 	provider "test" {}
            - 
              
              	provider "test" {}
              	... // 2 identical lines
              	"""
              )

…estStep merged configuration

Reference: #1064

Previously:

```
    --- FAIL: TestStepMergedConfig/teststep-externalproviders-config-with-provider-block-unquoted (0.00s)
        /Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/teststep_providers_test.go:643: unexpected difference:   (
              	"""
              	... // 6 identical lines
              	  }
              	}
            - 
            - 	provider "test" {}
            - 
              
              	provider test {}
              	... // 2 identical lines
              	"""
              )
    --- FAIL: TestStepMergedConfig/teststep-externalproviders-config-with-provider-block-quoted (0.00s)
        /Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/teststep_providers_test.go:643: unexpected difference:   (
              	"""
              	... // 6 identical lines
              	  }
              	}
            - 
            - 	provider "test" {}
            - 
              
              	provider "test" {}
              	... // 2 identical lines
              	"""
              )
```
@bflad bflad added bug Something isn't working subsystem/tests Issues and feature requests related to the testing framework. labels Nov 8, 2022
@bflad bflad added this to the v2.24.1 milestone Nov 8, 2022
@bflad bflad requested a review from a team as a code owner November 8, 2022 16:01
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 9523045 into main Nov 14, 2022
5 checks passed
@bflad bflad deleted the bflad/skip-provider-block branch November 14, 2022 15:43
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days . This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working subsystem/tests Issues and feature requests related to the testing framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK v2.23.0 provider merging causes duplicate provider test failures
2 participants