Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "unsupported test mode" message #925

Merged
merged 2 commits into from Apr 12, 2022
Merged

Improve "unsupported test mode" message #925

merged 2 commits into from Apr 12, 2022

Conversation

armsnyder
Copy link
Contributor

@armsnyder armsnyder commented Apr 2, 2022

The "unsupported test mode" message does not tell you which step of the test failed, unlike the other fatal errors in the runNewTest function here. This change adds the step number to the error message to make it more useful and more consistent.

The "unsupported test mode" message does not tell you which step of the test failed, unlike the other fatal errors in the `runNewTest` function here. This change adds the step number to the error message to make it more useful and more consistent.
@armsnyder armsnyder requested a review from as a code owner Apr 2, 2022
@hashicorp-cla
Copy link

@hashicorp-cla hashicorp-cla commented Apr 2, 2022

CLA assistant check
All committers have signed the CLA.

@bflad bflad added this to the v2.14.0 milestone Apr 5, 2022
@bflad bflad added the subsystem/tests label Apr 5, 2022
bflad
bflad approved these changes Apr 12, 2022
Copy link
Member

@bflad bflad left a comment

Thanks so much for this, @armsnyder 🚀

helper/resource/testing_new.go Outdated Show resolved Hide resolved
@bflad bflad merged commit 08f695a into hashicorp:main Apr 12, 2022
5 checks passed
@armsnyder armsnyder deleted the patch-1 branch Apr 12, 2022
@github-actions
Copy link

@github-actions github-actions bot commented May 13, 2022

I'm going to lock this pull request because it has been closed for 30 days . This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
subsystem/tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants