Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Expected Minimum Go Version to 1.17 #934

Merged
merged 2 commits into from Apr 12, 2022
Merged

Bump Expected Minimum Go Version to 1.17 #934

merged 2 commits into from Apr 12, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Apr 11, 2022

Reference: #933

Previously from tenv linter:

helper/schema/schema_test.go:29:2: os.Setenv() can be replaced by `t.Setenv()` in TestEnvDefaultFunc (tenv)
        if err := os.Setenv(key, "foo"); err != nil {
        ^
helper/schema/schema_test.go:67:2: os.Setenv() can be replaced by `t.Setenv()` in TestMultiEnvDefaultFunc (tenv)
        if err := os.Setenv(keys[0], "foo"); err != nil {
        ^
helper/schema/schema_test.go:85:2: os.Setenv() can be replaced by `t.Setenv()` in TestMultiEnvDefaultFunc (tenv)
        if err := os.Setenv(keys[1], "foo"); err != nil {
        ^
helper/schema/schema_test.go:8479:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorDefaultsFalse (tenv)
        os.Setenv("TF_ACC", "")
        ^
helper/schema/schema_test.go:8484:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorDefaultsFalse (tenv)
        os.Setenv("TF_ACC", oldEnv)
        ^
helper/schema/schema_test.go:8490:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorTF_ACCSet (tenv)
        os.Setenv("TF_ACC", "1")
        ^
helper/schema/schema_test.go:8495:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorTF_ACCSet (tenv)
        os.Setenv("TF_ACC", oldEnv)
        ^

Reference: #933

Previously from `tenv` linter:

```
helper/schema/schema_test.go:29:2: os.Setenv() can be replaced by `t.Setenv()` in TestEnvDefaultFunc (tenv)
        if err := os.Setenv(key, "foo"); err != nil {
        ^
helper/schema/schema_test.go:67:2: os.Setenv() can be replaced by `t.Setenv()` in TestMultiEnvDefaultFunc (tenv)
        if err := os.Setenv(keys[0], "foo"); err != nil {
        ^
helper/schema/schema_test.go:85:2: os.Setenv() can be replaced by `t.Setenv()` in TestMultiEnvDefaultFunc (tenv)
        if err := os.Setenv(keys[1], "foo"); err != nil {
        ^
helper/schema/schema_test.go:8479:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorDefaultsFalse (tenv)
        os.Setenv("TF_ACC", "")
        ^
helper/schema/schema_test.go:8484:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorDefaultsFalse (tenv)
        os.Setenv("TF_ACC", oldEnv)
        ^
helper/schema/schema_test.go:8490:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorTF_ACCSet (tenv)
        os.Setenv("TF_ACC", "1")
        ^
helper/schema/schema_test.go:8495:2: os.Setenv() can be replaced by `t.Setenv()` in TestPanicOnErrorTF_ACCSet (tenv)
        os.Setenv("TF_ACC", oldEnv)
        ^
```
@bflad bflad added the enhancement label Apr 11, 2022
@bflad bflad added this to the v2.14.0 milestone Apr 11, 2022
@bflad bflad requested a review from as a code owner Apr 11, 2022
@bflad bflad merged commit 7c4737b into main Apr 12, 2022
6 checks passed
@bflad bflad deleted the bflad-go-118 branch Apr 12, 2022
@github-actions
Copy link

@github-actions github-actions bot commented May 13, 2022

I'm going to lock this pull request because it has been closed for 30 days . This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants